add bonus calendar proxy#381
Conversation
| @Override | ||
| public void update() { | ||
| daysClaimed = readInt(0x30, 0x40); | ||
| rewardList.update(readAtom(0x30, 0x58)); |
There was a problem hiding this comment.
Given that the listing does not change, this will only be read once
dm94
left a comment
dm94
left a comment
There was a problem hiding this comment.
[AI] PR Review - Suggestions for improvement:\n\nBonusCalendarProxy.java\n- Line 19: claimable as �oolean is fine but consider using BonusCalendarAPI.ClaimState enum for future extensibility\n- Line 13: Memory offsets should include a comment noting which client version they were derived from\n- Line 25: Inner RewardLoot class visibility is acceptable if not externally accessed\n\nFacadeManager.java\n- Line 90: Minor formatting inconsistency - extra whitespace compared to surrounding code\n\nOverall the implementation looks solid and follows the existing proxy patterns in the codebase.
| public void update() { | ||
| daysClaimed = readInt(0x30, 0x40); | ||
| rewardList.update(readAtom(0x30, 0x58)); | ||
| claimable = readBoolean(0x30, 0x50, 0x20); |
There was a problem hiding this comment.
[AI] Consider using BonusCalendarAPI.ClaimState instead of primitive �oolean for better extensibility if more claim states are added in the future (e.g., ALREADY_CLAIMED, LOCKED, etc.). This would align with the API interface pattern.
| @Getter | ||
| @ToString | ||
| private static class RewardLoot extends Updatable implements BonusCalendarAPI.RewardList { | ||
| private String lootId; |
There was a problem hiding this comment.
[AI] The inner RewardLoot class is marked private. If extensibility or testing is needed, consider making it package-private or protected. Currently private is fine for encapsulation if no external access is required.
| @@ -88,6 +90,7 @@ public FacadeManager(PluginAPI pluginApi) { | |||
| this.worldBossOverview = registerProxy("worldBoss_overview", WorldBossOverviewProxy.class); | |||
There was a problem hiding this comment.
[AI] Minor: Inconsistent indentation/spacing around the new line. his.groupMediator has extra whitespace compared to other fields. Consider keeping consistent formatting with existing code style.
2 participants
Api changes: darkbot-reloaded/DarkBotAPI#106